Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle Source Link packages #31632

Merged
merged 9 commits into from
Apr 14, 2023
Merged

Bundle Source Link packages #31632

merged 9 commits into from
Apr 14, 2023

Conversation

tmat
Copy link
Member

@tmat tmat commented Apr 6, 2023 •
edited
Loading

Source Link targets are included automatically unless the project has already a PackageReference to any Source Link package.

Property SuppressImplicitGitSourceLink can be used to disable automatic inclusion of Source Link.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Apr 6, 2023
@tmat tmat marked this pull request as ready for review April 7, 2023 19:05
@tmat tmat force-pushed the SourceLinkSdk branch 2 times, most recently from ee262cb to 1797771 Compare April 7, 2023 19:18
@tmat tmat mentioned this pull request Apr 7, 2023
Merged
dsplaisted
dsplaisted approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@dsplaisted dsplaisted left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at the code for each sourcelink package, so I'm assuming those are good to be integrated into the SDK.

Once this flows into dotnet/installer, we should check to see whether the sourcelink SDKs are appropriately crossgen'd.

src/Assets/TestProjects/SourceLinkTestApp/SourceLinkTestApp.csproj Outdated Show resolved Hide resolved
src/Layout/redist/targets/RestoreDependency.proj Show resolved Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.SourceLink.props Outdated Show resolved Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.SourceLink.targets Outdated Show resolved Hide resolved
src/Tests/Microsoft.NET.Build.Tests/SourceLinkTests.cs Show resolved Hide resolved
@tmat tmat force-pushed the SourceLinkSdk branch 3 times, most recently from fa8b410 to 9bf222c Compare April 10, 2023 03:36
@tmat tmat mentioned this pull request Apr 11, 2023
Closed
@build-analysis build-analysis bot mentioned this pull request Apr 13, 2023
Closed
5 tasks
@tmat tmat enabled auto-merge (squash) April 14, 2023 16:07
@tmat tmat merged commit dd2e7b5 into dotnet:main Apr 14, 2023
@tmat tmat deleted the SourceLinkSdk branch April 15, 2023 00:31
@MichaelSimons MichaelSimons mentioned this pull request Apr 18, 2023
Merged
@ViktorHofer ViktorHofer mentioned this pull request May 4, 2023
Merged
@MichaelSimons MichaelSimons mentioned this pull request May 11, 2023
Closed
@baronfel baronfel mentioned this pull request Jun 6, 2023
Closed
3 tasks
@NikolaMilosavljevic NikolaMilosavljevic mentioned this pull request Jul 10, 2023
Merged
This was referenced Aug 2, 2023
Closed
Merged
@baronfel baronfel added the breaking-change Using this label will notify dotnet/compat and trigger a request to file a compat bug label Oct 23, 2023
@ghost
Copy link

ghost commented Oct 23, 2023 •
edited by baronfel
Loading

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@baronfel baronfel mentioned this pull request Oct 23, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KalleOlaviNiemitalo KalleOlaviNiemitalo KalleOlaviNiemitalo left review comments

@dsplaisted dsplaisted dsplaisted approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure breaking-change Using this label will notify dotnet/compat and trigger a request to file a compat bug untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmat @dsplaisted @KalleOlaviNiemitalo @baronfel